----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/299/#review472 -----------------------------------------------------------
Love it. One thing I'd like to see would be to strip BUILD_DIR from the file name when printing. I can do that in a separate changeset though if you prefer. SConstruct <http://reviews.m5sim.org/r/299/#comment694> I think that you should do this one the same way that you do the others with the getOutput function src/SConscript <http://reviews.m5sim.org/r/299/#comment695> perhaps it would be better to have a MakeAction() function that buries the *getOutput code inside and just does something like: def MakeAction(func, string): if env['VERBOSE']: return Action(func) else: return Action(func, string) - Nathan On 2010-11-09 18:59:43, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/299/ > ----------------------------------------------------------- > > (Updated 2010-11-09 18:59:43) > > > Review request for Default. > > > Summary > ------- > > Scons: Try to make SCons output prettier. > > This change has scons print [ C], [CC], [LN], etc in front of normal commands > instead of the entire command themselves and cleans up the build a good bit. > Unfortunately, I couldn't figure out a way to get the same behavior from > env.Command() calls so they're still verbose. > > Thoughts? Like it? Hate it? > > > Diffs > ----- > > SConstruct f4362ffd810f > src/SConscript f4362ffd810f > src/arch/isa_parser.py f4362ffd810f > src/cpu/SConscript f4362ffd810f > > Diff: http://reviews.m5sim.org/r/299/diff > > > Testing > ------- > > > Thanks, > > Ali > >
_______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
