Patch Set 3: (1 comment)
https://gerrit.osmocom.org/#/c/2868/3/openbsc/src/libbsc/abis_nm.c File openbsc/src/libbsc/abis_nm.c: Line 1595: if (bts->type != GSM_BTS_TYPE_OSMOBTS) { > hmm having learned from nanobts->sysmobts checks... we should avoid direct I actually think this is correct here. We are moving towards simply stating "osmobts" as BTS model in the openbsc.cfg, and then having exactly this code figuring out the specific model/version/capabilities of the OsmoBTS on the other end. So it makes sense with TYPE_OSMOBTS but not with NANOBTS or any other IPA bts model. If anything, "bts model sysmobts" in the config is going to be a sysnonym to "bts model osmobts", if it isn't already. -- To view, visit https://gerrit.osmocom.org/2868 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f43055c38000248033a8ff9ddaf0910d68d794b Gerrit-PatchSet: 3 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Holger Freyther <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <[email protected]> Gerrit-HasComments: Yes
