Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/#/c/2868/3/openbsc/src/libbsc/abis_nm.c
File openbsc/src/libbsc/abis_nm.c:

Line 1595:      if (bts->type != GSM_BTS_TYPE_OSMOBTS) {
> I actually think this is correct here.  We are moving towards simply statin
"bts model sysmobts" is deprecated but I wondered why we still check type and 
not features. Anyway let's not have this discussion right now and here.


-- 
To view, visit https://gerrit.osmocom.org/2868
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f43055c38000248033a8ff9ddaf0910d68d794b
Gerrit-PatchSet: 3
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Max <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Holger Freyther <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <[email protected]>
Gerrit-HasComments: Yes

Reply via email to