Patch Set 2: You are sending the GET_ATTRIBUTE OML message to each bts type, and that includes an E1 based BTS. Assuming what that BTS will do when receiving such a message with a "wrong" BTS number can be dangerous. Also, if the calls were specifically added for osmoBTS, why are they not subject to related conditionals? They could simply be issued only in case "OsmoBTS" is selected as bts->type.
-- To view, visit https://gerrit.osmocom.org/2868 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f43055c38000248033a8ff9ddaf0910d68d794b Gerrit-PatchSet: 2 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <[email protected]> Gerrit-HasComments: No
