Patch Set 1: (1 comment)
https://gerrit.osmocom.org/#/c/2868/1/openbsc/src/libbsc/bsc_init.c File openbsc/src/libbsc/bsc_init.c: Line 346: abis_nm_get_attr(trx->bts, NM_OC_BTS, 0xFF, 0xFF, 0xFF, bts_attr, sizeof(bts_attr)); > I think removing trx->nr makes a lot of sens. But for bts->nr, I'm not sur The classic E1 should not be affected by this at all: the calls to oml_nm_get_attr() were added specifically for OS#1614 "better identification of BTS model" so any changes to it should not have effect on classic E1 BTS which would most likely ignore it. -- To view, visit https://gerrit.osmocom.org/2868 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f43055c38000248033a8ff9ddaf0910d68d794b Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <[email protected]> Gerrit-HasComments: Yes
