Patch Set 1: Code-Review-1 (2 comments)
https://gerrit.osmocom.org/#/c/2868/1/openbsc/src/libbsc/bsc_init.c File openbsc/src/libbsc/bsc_init.c: Line 351 this is most certainly wrong for multi-trx setups. We iterate over the list of transceivers and we have to use the id of the respective transceiver. Line 346: abis_nm_get_attr(trx->bts, NM_OC_BTS, 0xFF, 0xFF, 0xFF, bts_attr, sizeof(bts_attr)); I think removing trx->nr makes a lot of sens. But for bts->nr, I'm not sure. Any change here would have to be validated with both classic E1 based multi-BTS setups as well as abis_ip. -- To view, visit https://gerrit.osmocom.org/2868 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f43055c38000248033a8ff9ddaf0910d68d794b Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes
