Patch Set 3: Code-Review-1 (1 comment)
https://gerrit.osmocom.org/#/c/2868/3/openbsc/src/libbsc/abis_nm.c File openbsc/src/libbsc/abis_nm.c: Line 1595: if (bts->type != GSM_BTS_TYPE_OSMOBTS) { hmm having learned from nanobts->sysmobts checks... we should avoid direct bts->type comparisons... -- To view, visit https://gerrit.osmocom.org/2868 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f43055c38000248033a8ff9ddaf0910d68d794b Gerrit-PatchSet: 3 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Holger Freyther <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <[email protected]> Gerrit-HasComments: Yes
