jcamachor commented on a change in pull request #866: HIVE-22536 Improve return
path enabling/disabling
URL: https://github.com/apache/hive/pull/866#discussion_r357506813
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java
##########
@@ -464,7 +464,7 @@ Operator genOPTree(ASTNode ast, PlannerContext plannerCtx)
throws SemanticExcept
// 0. Gen Optimized Plan
RelNode newPlan = logicalPlan();
- if (this.conf.getBoolVar(HiveConf.ConfVars.HIVE_CBO_RETPATH_HIVEOP))
{
+ if (ReturnPathManager.shouldUse()) {
if (cboCtx.type == PreCboCtx.Type.VIEW && !materializedView) {
Review comment:
We should only fail if return path is `true` rather than `supported`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
