jcamachor commented on a change in pull request #866: HIVE-22536 Improve return
path enabling/disabling
URL: https://github.com/apache/hive/pull/866#discussion_r357789226
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java
##########
@@ -3025,8 +3025,7 @@ private RelNode genTableLogicalPlan(String tableAlias,
QB qb) throws SemanticExc
db, tabNameToTabObject, partitionCache, colStatsCache,
noColsMissingStats);
final TableScan scan = new HiveTableScan(cluster,
cluster.traitSetOf(HiveRelNode.CONVENTION),
optTable, null == tableAlias ? tabMetaData.getTableName() :
tableAlias,
- getAliasId(tableAlias, qb), HiveConf.getBoolVar(conf,
- HiveConf.ConfVars.HIVE_CBO_RETPATH_HIVEOP),
qb.isInsideView()
+ getAliasId(tableAlias, qb), ReturnPathManager.shouldUse(),
qb.isInsideView()
Review comment:
We should try with `false` hardcoded. If we set it to `true` by default, I
believe it will change aliases for all plans once we enable return path (which
also makes it more difficult to debug queries since these are synthetic aliases
vs the aliases specified in the SQL query). Note that the boolean is used in
`explainTerms` in `HiveTableScan` and the path for value `false` has changed
since this boolean was created: I do not recall all details, but it may be that
things work properly currently if we just set the value to `false`. A good way
to verify would be to run all q tests matching `cbo_.*` hardcoding it to
`false` in the `HiveTableScan` creation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
