jcamachor commented on a change in pull request #866: HIVE-22536 Improve return
path enabling/disabling
URL: https://github.com/apache/hive/pull/866#discussion_r357782071
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java
##########
@@ -464,7 +464,7 @@ Operator genOPTree(ASTNode ast, PlannerContext plannerCtx)
throws SemanticExcept
// 0. Gen Optimized Plan
RelNode newPlan = logicalPlan();
- if (this.conf.getBoolVar(HiveConf.ConfVars.HIVE_CBO_RETPATH_HIVEOP))
{
+ if (ReturnPathManager.shouldUse()) {
if (cboCtx.type == PreCboCtx.Type.VIEW && !materializedView) {
Review comment:
If it is a create view statement, we fail with `Create view is not supported
in cbo return path.`. I would expect that since view creation is not supported
in cbo return path, we just either 1) do not use return path for view creation,
or 2) we only fail if we are setting this to `true`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
