jcamachor commented on a change in pull request #866: HIVE-22536 Improve return
path enabling/disabling
URL: https://github.com/apache/hive/pull/866#discussion_r357510056
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java
##########
@@ -3025,8 +3025,7 @@ private RelNode genTableLogicalPlan(String tableAlias,
QB qb) throws SemanticExc
db, tabNameToTabObject, partitionCache, colStatsCache,
noColsMissingStats);
final TableScan scan = new HiveTableScan(cluster,
cluster.traitSetOf(HiveRelNode.CONVENTION),
optTable, null == tableAlias ? tabMetaData.getTableName() :
tableAlias,
- getAliasId(tableAlias, qb), HiveConf.getBoolVar(conf,
- HiveConf.ConfVars.HIVE_CBO_RETPATH_HIVEOP),
qb.isInsideView()
+ getAliasId(tableAlias, qb), ReturnPathManager.shouldUse(),
qb.isInsideView()
Review comment:
It may not be necessary to pass that boolean when we create HiveTableScan
operators anymore, since there was some follow-up work that included the alias
with the table name in the digest. If that is the case, we can remove it.
Otherwise, it seems it is OK that we pass true even if finally we end up
bailing out from return path when we check the operators/expressions in the
plan.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
