jcamachor commented on a change in pull request #866: HIVE-22536 Improve return 
path enabling/disabling
URL: https://github.com/apache/hive/pull/866#discussion_r358611969
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java
 ##########
 @@ -464,7 +464,7 @@ Operator genOPTree(ASTNode ast, PlannerContext plannerCtx) 
throws SemanticExcept
           // 0. Gen Optimized Plan
           RelNode newPlan = logicalPlan();
 
-          if (this.conf.getBoolVar(HiveConf.ConfVars.HIVE_CBO_RETPATH_HIVEOP)) 
{
+          if (ReturnPathManager.shouldUse()) {
             if (cboCtx.type == PreCboCtx.Type.VIEW && !materializedView) {
 
 Review comment:
   > Or is it the case, that eventually we'll use RP for view creation as well?
   Exactly, this should be the case so we hit same validation path for queries 
and views.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to