jcamachor commented on a change in pull request #866: HIVE-22536 Improve return path enabling/disabling URL: https://github.com/apache/hive/pull/866#discussion_r357789921
########## File path: ql/src/java/org/apache/hadoop/hive/ql/parse/ReturnPathManager.java ########## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.hive.ql.parse; + +import org.apache.hadoop.hive.conf.HiveConf; + +/** + * This is a temporary class for the time while we are in transition to use return path only. + * It's purpose is to decide if Hive should use return path. + */ +public final class ReturnPathManager { + private ReturnPathManager() { + throw new UnsupportedOperationException("ReturnPathManager should not be instantiated"); + } + + private static ThreadLocal<Boolean> useReturnPath = new ThreadLocal<>(); + + public static void init(HiveConf conf, ASTNode root) { + boolean use = shouldUseReturnPath(conf, root); + useReturnPath.set(use); + } + + public static boolean shouldUse() { + return useReturnPath.get(); + } + + private static boolean shouldUseReturnPath(HiveConf conf, ASTNode root) { Review comment: If possible, let's remove those usages as we are discussing above... It is easier to do this check on the Calcite plan since optimizations may introduce/remove operators and expressions that are supported/unsupported. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
