WillAyd commented on code in PR #2740:
URL: https://github.com/apache/arrow-adbc/pull/2740#discussion_r2063603233


##########
c/driver/bigquery/adbc-driver-bigquery.pc.in:
##########
@@ -23,3 +23,4 @@ Description: The ADBC BigQuery driver provides an ADBC driver 
for BigQuery.
 URL: https://github.com/apache/arrow-adbc
 Version: @ADBC_VERSION@
 Libs: -L${libdir} -ladbc_driver_bigquery
+Libs.private: -DADBC_STATIC

Review Comment:
   I don't think the modules built by Go (bigquery, flightsql, snowflake) would 
ever be static (?) so perhaps this is superfluous, but I figured worth keeping 
for consistency with other .pc files



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to