damccorm commented on code in PR #28750:
URL: https://github.com/apache/beam/pull/28750#discussion_r1342677387
##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -429,7 +429,7 @@ class BeamModulePlugin implements Plugin<Project> {
}
def isRelease(Project project) {
- return parseBooleanProperty(project, 'isRelease');
+ return !project.version.endsWith('-SNAPSHOT')
Review Comment:
Doesn't this remove our ability to run non-release jobs against the RC
commit before we're ready to publish the release?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
