kennknowles commented on PR #28750:
URL: https://github.com/apache/beam/pull/28750#issuecomment-1747767220
Ah, I got confused by `job` which I was thinking in terms of GitHub Actions
or Dataflow or something. Yes, Gradle tasks that change their behavior on this
flag are a nuisance.
Reviewing the usage, it has these different purposes which are all included
in a release but none require a special `isRelease` boolean:
- Signing the artifacts: if a signing key is provided, that would be
enough. We probably do want to sign by default for non-SNAPSHOT versions but
have a `-PskipSigning` property, so the result of this PR is right.
- Controlling whether docker images are pushed. This should just be an
independent task.
- Extensive setup of the maven publish plugin. Highly suspect area of our
gradle, but leaving it alone.
- Hardcoding list of released architectures. Probably similar protocol to
signing is appropriate.
- Whether the metadata indicates the snapshot dist maven repo. This is
actually a good use, conceptually, but should _directly_ depend on whether we
are issuing a command to publish to the snapshot repo.
To be clear I'm mostly intending to leave the functionality at status quo,
except cleaning up an extraneous flag and an incorrect version manipulation
that broke the build of 2.51.0 RC1.
I see builds are breaking so I'll iterate on this when I can get back to it,
but signing off today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
