kennknowles commented on PR #28750: URL: https://github.com/apache/beam/pull/28750#issuecomment-1748638029
Having slept on it, I realized a couple things: 1. The `isRelease` flag probably dates back to an obsolete time were we tried to build a non-SNAPSHOT / non-dev version from a commit that was at a -SNAPSHOT / .dev version, by dynamically changing it, and then its use spread. 2. This is actually a few different rabbit holes and I only want to fix the version issue that interfered with the release, and handle the other problems separately. I'll just make a new PR since that'll be nearly trivial. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
