kennknowles commented on code in PR #28750:
URL: https://github.com/apache/beam/pull/28750#discussion_r1346548493
##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -429,7 +429,7 @@ class BeamModulePlugin implements Plugin<Project> {
}
def isRelease(Project project) {
- return parseBooleanProperty(project, 'isRelease');
+ return !project.version.endsWith('-SNAPSHOT')
Review Comment:
Oh yes, I'm aware of it being baked in all over the place, that's why I left
it. Builds at the RC commit should always have `-PisRelease` or they won't do
what we need to do with the RC.
If we have a job that expects the version to end in `-SNAPSHOT` that job is
probably broken.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
