kennknowles commented on code in PR #28750:
URL: https://github.com/apache/beam/pull/28750#discussion_r1346563378


##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -429,7 +429,7 @@ class BeamModulePlugin implements Plugin<Project> {
   }
 
   def isRelease(Project project) {
-    return parseBooleanProperty(project, 'isRelease');
+    return !project.version.endsWith('-SNAPSHOT')

Review Comment:
   Converted to assigning a boolean, deliberately causing any dependencies on 
the prior function to break so we can catch them in review.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to