damccorm commented on code in PR #28750:
URL: https://github.com/apache/beam/pull/28750#discussion_r1346321387
##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -429,7 +429,7 @@ class BeamModulePlugin implements Plugin<Project> {
}
def isRelease(Project project) {
- return parseBooleanProperty(project, 'isRelease');
+ return !project.version.endsWith('-SNAPSHOT')
Review Comment:
"the RC commit" - the commit that we tag for a release candidate. E.g.
https://github.com/apache/beam/tree/v2.51.0-RC1
"non-release jobs" - any job that was previously expecting the version to
end in `-SNAPSHOT` or has other expectations depending on the `isRelease`
variable. This expectation is baked in all over the place FWIW -
https://github.com/search?q=repo%3Aapache%2Fbeam+isRelease+language%3AGradle&type=code&l=Gradle
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
