kennknowles commented on code in PR #28750:
URL: https://github.com/apache/beam/pull/28750#discussion_r1346548965
##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -429,7 +429,7 @@ class BeamModulePlugin implements Plugin<Project> {
}
def isRelease(Project project) {
- return parseBooleanProperty(project, 'isRelease');
+ return !project.version.endsWith('-SNAPSHOT')
Review Comment:
I do need to fix the ones that are directly checking `hasProperty` instead
of calling the method though.
Eventually we should be eliminating this concept, which should probably not
exist.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
