Nyrox commented on code in PR #1435:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1435#discussion_r1796656561
##########
tests/sqlparser_common.rs:
##########
@@ -9805,6 +9853,7 @@ fn parse_map_access_expr() {
#[test]
fn parse_connect_by() {
let expect_query = Select {
+ select_token: TokenWithLocation::wrap(Token::make_keyword("SELECT")),
Review Comment:
Yeah I agree it can be a bit tricky. For this particular case it doesn't
matter I think, because TokenWithLocation's custom Eq implementation ignoring
spans. So as long as selects actually have _a_ select token they will compare.
What actually is the use case of having Eq on ast nodes? I guess it's so you
can throw them into HashMaps?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
