iffyio commented on code in PR #1435:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1435#discussion_r1797561241
##########
tests/sqlparser_common.rs:
##########
@@ -9805,6 +9853,7 @@ fn parse_map_access_expr() {
#[test]
fn parse_connect_by() {
let expect_query = Select {
+ select_token: TokenWithLocation::wrap(Token::make_keyword("SELECT")),
Review Comment:
Ah, no my mistake I missed that the span is being ignored in the comparison
here as well. the actual token isn't currently ignored however? thinking that
potentially makes it awkward needing to figure out what a token on a property
should be, and not sure if there are guarantees provided by the parser on its
value? (I'm assuming having the token included in the node is useful)
Not only Eq, but PartialEq as well, basically thinking as with today, any
two subexpressions should remain equal regardless of what part of the tree they
show up in (for example required when taking fingerprints of sql and comparing
them)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
