[
https://issues.apache.org/jira/browse/BEAM-7428?focusedWorklogId=258149&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-258149
]
ASF GitHub Bot logged work on BEAM-7428:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Jun/19 21:43
Start Date: 11/Jun/19 21:43
Worklog Time Spent: 10m
Work Description: jkff commented on issue #8741: [BEAM-7428] Output the
timestamp on elements in ReadAllViaFileBasedSource
URL: https://github.com/apache/beam/pull/8741#issuecomment-501034883
I'm not sure I follow. Sounds like you're talking about
ProcessContext.updateWatermark()? It is true that this API is only implemented
for SDFs (even though technically we could support it for regular DoFns too),
but I don't see how it answers the question of this PR, which timestamp should
we output with. That API still does not make outputting backwards in time be
permitted.
Perhaps the correct thing to do is to make BoundedSource.getCurrentTimestamp
be `@Nullable`, where null means "I don't know the timestamp". Then if it's
null then use the source's timestamp, else use the provided timestamp. That
seems better than the current treatment, where BoundedSource by default
pretends that all its elements are actually infinitely old.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 258149)
Time Spent: 4h 40m (was: 4.5h)
> ReadAllViaFileBasedSource does not output the timestamps of the read elements
> -----------------------------------------------------------------------------
>
> Key: BEAM-7428
> URL: https://issues.apache.org/jira/browse/BEAM-7428
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Ismaël Mejía
> Assignee: Ismaël Mejía
> Priority: Minor
> Time Spent: 4h 40m
> Remaining Estimate: 0h
>
> This differs from the implementation of JavaReadViaImpulse that tackles a
> similar problem but does output the timestamps correctly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
