[
https://issues.apache.org/jira/browse/BEAM-7428?focusedWorklogId=257014&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-257014
]
ASF GitHub Bot logged work on BEAM-7428:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Jun/19 17:27
Start Date: 10/Jun/19 17:27
Worklog Time Spent: 10m
Work Description: lukecwik commented on issue #8741: [BEAM-7428] Output
the timestamp on elements in ReadAllViaFileBasedSource
URL: https://github.com/apache/beam/pull/8741#issuecomment-500505080
@iemejia
How do you resolve the case where you want to track the timestamp of the
file as the output timestamp instead of the boundedsources timestamp. For
example, the
[Watch](https://github.com/apache/beam/blob/9428cc8c6fbffe7190c923850acbd98474210ad7/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Watch.java#L754)
transform sets the timestamp on the output. It would make sense that a user
may want to use the timestamp there instead of the timestamp stored within the
boundedsource. I think in most cases your change is the change that people want.
@chamikaramj
It is unlikely that they are different for most sources but the
[Watch](https://github.com/apache/beam/blob/9428cc8c6fbffe7190c923850acbd98474210ad7/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Watch.java#L754)
transform does meaningfully set it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 257014)
Time Spent: 3h 40m (was: 3.5h)
> ReadAllViaFileBasedSource does not output the timestamps of the read elements
> -----------------------------------------------------------------------------
>
> Key: BEAM-7428
> URL: https://issues.apache.org/jira/browse/BEAM-7428
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Ismaël Mejía
> Assignee: Ismaël Mejía
> Priority: Minor
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> This differs from the implementation of JavaReadViaImpulse that tackles a
> similar problem but does output the timestamps correctly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
