[
https://issues.apache.org/jira/browse/BEAM-7428?focusedWorklogId=257311&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-257311
]
ASF GitHub Bot logged work on BEAM-7428:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Jun/19 01:37
Start Date: 11/Jun/19 01:37
Worklog Time Spent: 10m
Work Description: jkff commented on issue #8741: [BEAM-7428] Output the
timestamp on elements in ReadAllViaFileBasedSource
URL: https://github.com/apache/beam/pull/8741#issuecomment-500652579
I think we discussed this before, and concluded that
reader.getCurrentTimestamp() ought to return a timestamp greater than timestamp
of the element being read, which is consistent with watermark logic everywhere
in Beam (including SDF): you can output forward in time but not backward.
Most BoundedSource's indeed output at -INF, which is inconsistent with the
above. On the other hand, you could argue that they do so because they assume
their source itself has a timestamp of -INF, and what they really mean is
"output at the timestamp of my source"?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 257311)
Time Spent: 4h (was: 3h 50m)
> ReadAllViaFileBasedSource does not output the timestamps of the read elements
> -----------------------------------------------------------------------------
>
> Key: BEAM-7428
> URL: https://issues.apache.org/jira/browse/BEAM-7428
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Ismaël Mejía
> Assignee: Ismaël Mejía
> Priority: Minor
> Time Spent: 4h
> Remaining Estimate: 0h
>
> This differs from the implementation of JavaReadViaImpulse that tackles a
> similar problem but does output the timestamps correctly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
