[
https://issues.apache.org/jira/browse/BEAM-7428?focusedWorklogId=258239&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-258239
]
ASF GitHub Bot logged work on BEAM-7428:
----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Jun/19 00:29
Start Date: 12/Jun/19 00:29
Worklog Time Spent: 10m
Work Description: jkff commented on issue #8741: [BEAM-7428] Output the
timestamp on elements in ReadAllViaFileBasedSource
URL: https://github.com/apache/beam/pull/8741#issuecomment-501073829
But there's no API for holding the watermark: on the contrary,
updateWatermark() allows the watermark to progress *faster* than it otherwise
would, not slower - e.g. it allows the watermark to progress gradually as parts
of the restriction are processed, as opposed to having it stay at (element
timestamp) and then jump to +INF only when the whole restriction is done.
In the current PR, I think we shouldn't deal with watermark at all. Just
make getCurrentTimestamp able to return "unknown" and fall back to element
timestamp if unknown.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 258239)
Time Spent: 5h (was: 4h 50m)
> ReadAllViaFileBasedSource does not output the timestamps of the read elements
> -----------------------------------------------------------------------------
>
> Key: BEAM-7428
> URL: https://issues.apache.org/jira/browse/BEAM-7428
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Ismaël Mejía
> Assignee: Ismaël Mejía
> Priority: Minor
> Time Spent: 5h
> Remaining Estimate: 0h
>
> This differs from the implementation of JavaReadViaImpulse that tackles a
> similar problem but does output the timestamps correctly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
