zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface URL: https://github.com/apache/flink/pull/8608#discussion_r290566895
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServicesConfiguration.java ########## @@ -78,33 +77,32 @@ private Optional<Time> systemResourceMetricsProbingInterval; public TaskManagerServicesConfiguration( - InetAddress taskManagerAddress, - String[] tmpDirPaths, - String[] localRecoveryStateRootDirectories, - boolean localRecoveryEnabled, - NetworkEnvironmentConfiguration networkConfig, - @Nullable QueryableStateConfiguration queryableStateConfig, - int numberOfSlots, - long configuredMemory, - MemoryType memoryType, - boolean preAllocateMemory, - float memoryFraction, - long timerServiceShutdownTimeout, - RetryingRegistrationConfiguration retryingRegistrationConfiguration, - Optional<Time> systemResourceMetricsProbingInterval) { + InetAddress taskManagerAddress, Review comment: Keep the previous indentation ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services