zhijiangW commented on a change in pull request #8608: [FLINK-11392][network]
Introduce ShuffleEnvironment interface
URL: https://github.com/apache/flink/pull/8608#discussion_r290571622
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NetworkEnvironment.java
##########
@@ -409,6 +382,7 @@ public void shutdown() {
}
}
+ @Override
Review comment:
ATM this method is only used for testing, so it seems no reasonable to
define an interface method only for testing. If the previous test could be
refactored not relying on this method. I ever considered this issue to remove
this method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
