zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] 
Introduce ShuffleEnvironment interface
URL: https://github.com/apache/flink/pull/8608#discussion_r290570744
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NetworkEnvironment.java
 ##########
 @@ -129,11 +128,11 @@ public static NetworkEnvironment fromConfiguration(
                        maxJvmHeapMemory,
                        localTaskManagerCommunication,
                        taskManagerAddress);
-               return NetworkEnvironment.create(networkConfig, 
taskEventPublisher, metricGroup, ioManager);
+               return create(networkConfig, taskEventPublisher, metricGroup, 
ioManager);
        }
 
        public static NetworkEnvironment create(
-                       NetworkEnvironmentConfiguration config,
+               NetworkEnvironmentConfiguration config,
 
 Review comment:
   See the changes for commit `[FLINK-11392][network] Introduce 
ShuffleEnvironment interface`, this indentation should not be changed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to