zhijiangW commented on a change in pull request #8608: [FLINK-11392][network]
Introduce ShuffleEnvironment interface
URL: https://github.com/apache/flink/pull/8608#discussion_r290571356
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NetworkEnvironment.java
##########
@@ -322,19 +302,10 @@ private void registerInputMetrics(MetricGroup
inputGroup, MetricGroup buffersGro
buffersGroup.gauge(METRIC_INPUT_POOL_USAGE, new
InputBufferPoolUsageGauge(inputGates));
}
- /**
- * Update consuming gate with newly available partition.
- *
- * @param consumerID execution id of consumer to identify belonging to
it gate.
- * @param partitionInfo telling where the partition can be retrieved
from
- * @return {@code true} if the partition has been updated or {@code
false} if the partition is not available anymore.
- * @throws IOException IO problem by the update
- * @throws InterruptedException potentially blocking operation was
interrupted
- * @throws IllegalStateException the input gate with the id from the
partitionInfo is not found
- */
+ @Override
public boolean updatePartitionInfo(
- ExecutionAttemptID consumerID,
- PartitionInfo partitionInfo) throws IOException,
InterruptedException {
+ ExecutionAttemptID consumerID,
Review comment:
ditto: keep previous indentation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
