zhijiangW commented on a change in pull request #8608: [FLINK-11392][network]
Introduce ShuffleEnvironment interface
URL: https://github.com/apache/flink/pull/8608#discussion_r290568168
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskManagerServicesConfigurationTest.java
##########
@@ -36,7 +37,7 @@
private static final long MEM_SIZE_PARAM = 128L * 1024 * 1024;
/**
- * Verifies that {@link
TaskManagerServicesConfiguration#fromConfiguration(Configuration, long,
InetAddress, boolean)}
+ * Verifies that {@link
TaskManagerServicesConfiguration#fromConfiguration(Configuration, InetAddress)}
Review comment:
I think this test is only for verifying the generation of
`NetworkEnvironmentConfiguration`. The scope of
`TaskManagerServicesConfiguration#fromConfiguration` covers many things. Also
this class name `TaskManagerServicesConfigurationTest` might also be renamed to
`NetworkEnvironmentConfigurationTest` or something else.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
