zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] 
Introduce ShuffleEnvironment interface
URL: https://github.com/apache/flink/pull/8608#discussion_r290567675
 
 

 ##########
 File path: 
flink-runtime/src/test/java/org/apache/flink/runtime/state/TaskExecutorLocalStateStoresManagerTest.java
 ##########
 @@ -205,17 +205,20 @@ private void checkRootDirsClean(File[] rootDirs) {
        private TaskManagerServicesConfiguration 
createTaskManagerServiceConfiguration(
                        Configuration config) throws IOException {
                return TaskManagerServicesConfiguration.fromConfiguration(
-                       config, MEM_SIZE_PARAM, InetAddress.getLocalHost(), 
true);
+                       config, InetAddress.getLocalHost());
 
 Review comment:
   separate line for every parameter or we do not need break line here because 
it might not be long after removing above parameters.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to