zhijiangW commented on a change in pull request #8608: [FLINK-11392][network]
Introduce ShuffleEnvironment interface
URL: https://github.com/apache/flink/pull/8608#discussion_r290568555
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NetworkEnvironment.java
##########
@@ -114,6 +116,22 @@ private NetworkEnvironment(
this.isShutdown = false;
}
+ public static NetworkEnvironment fromConfiguration(
Review comment:
It might be better to put this static factory at the end of this class, also
for the following `create` method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
