azagrebin commented on a change in pull request #10146: [FLINK-14188][runtime]
TaskExecutor derive and register with default slot resource profile
URL: https://github.com/apache/flink/pull/10146#discussion_r348400241
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/TaskExecutorResourceUtils.java
##########
@@ -587,6 +588,23 @@ private static double getCpuCores(final Configuration
config) {
return config.getDouble(TaskManagerOptions.CPU_CORES_KEY, -1.0);
}
+ @SuppressWarnings("deprecation")
+ private static double getDefaultSlotFraction(final Configuration
config) {
Review comment:
nit code style: could we put this method after the method which uses it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
