azagrebin commented on a change in pull request #10146: [FLINK-14188][runtime]
TaskExecutor derive and register with default slot resource profile
URL: https://github.com/apache/flink/pull/10146#discussion_r348377455
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java
##########
@@ -34,6 +34,13 @@
@ConfigGroups(groups = @ConfigGroup(name = "TaskManagerMemory", keyPrefix =
"taskmanager.memory"))
public class TaskManagerOptions {
+ /**
+ * This config key is used for passing cpu cores into TaskExecutors.
+ * There're YarrConfigOptions#VCORES and
MesosTaskManagerParameters#MESOS_RM_TASKS_CPUS for configuring TM container
+ * CPU on Yarn and Mesos respectively.
+ */
+ public static final String CPU_CORES_KEY = "taskmanager.cpu.cores";
Review comment:
do we not want a normal option for this?
it seems user will not be able to declare the CPUs for standalone and TMs
will then match all requests.
If we introduce this new option, we could consider deprecating `VCORES` and
`MESOS_RM_TASKS_CPUS` in favour of the new option, like `MESOS_RM_TASKS_SLOTS`
is actually `NUM_TASK_SLOTS`.
Arguably, the default value for this new option could fallback to the number
of slots, also for standalone, like it is now for yarn/mesos but it is
technically change of behaviour as now standalone TMs accept all requests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
