azagrebin commented on a change in pull request #10146: [FLINK-14188][runtime]
TaskExecutor derive and register with default slot resource profile
URL: https://github.com/apache/flink/pull/10146#discussion_r348476905
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManagerGateway.java
##########
@@ -104,6 +106,7 @@
ResourceID resourceId,
int dataPort,
HardwareDescription hardwareDescription,
+ ResourceProfile defaultSlotResourceProfile,
Review comment:
Looks like we keep exploding arguments for this method. It would be nice to
add a hotfix commit with a refactoring where this method accepts a class
container for those parameters, like
`TaskExecutorByResourceManagerRegistration` or something.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
