azagrebin commented on a change in pull request #10146: [FLINK-14188][runtime]
TaskExecutor derive and register with default slot resource profile
URL: https://github.com/apache/flink/pull/10146#discussion_r348472587
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/TaskExecutorResourceSpec.java
##########
@@ -186,6 +192,21 @@ public MemorySize getJvmDirectMemorySize() {
return
frameworkOffHeapMemorySize.add(taskOffHeapSize).add(shuffleMemSize);
}
+ public double getDefaultSlotFraction() {
+ return defaultSlotFraction;
+ }
+
+ public ResourceProfile getDefaultSlotResourceProfile() {
Review comment:
I would not add one more concern of default profile to
`TaskExecutorResourceSpec`.
`TaskExecutorResourceSpecUtils` could have a factory method for the default
profile:
`ResourceProfile generateDefaultSlotResourceProfile(config(,
TaskExecutorResourceSpec))`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
