azagrebin commented on a change in pull request #10146: [FLINK-14188][runtime]
TaskExecutor derive and register with default slot resource profile
URL: https://github.com/apache/flink/pull/10146#discussion_r348344091
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java
##########
@@ -136,6 +138,20 @@
" is typically proportional to the number of
physical CPU cores that the TaskManager's machine has" +
" (e.g., equal to the number of cores, or half
the number of cores).");
+ /**
+ * Fraction of TaskExecutor resources a default slot should take for
slot requests with unknown resource profiles.
+ */
+ @Documentation.CommonOption(position =
Documentation.CommonOption.POSITION_PARALLELISM_SLOTS)
+ public static final ConfigOption<Float> DEFAULT_SLOT_FRACTION =
+ key("taskmanager.default-slot-fraction")
+ .defaultValue(-1.0f)
Review comment:
I am wondering whether we should already now align the default value with
the default `NUM_TASK_SLOTS`, basically set it to `1.0f`. If we remove
`NUM_TASK_SLOTS` at some point, then this option stays independent but we can
still check now whether it has been explicitly set by users or not to decide
whether to fallback to `NUM_TASK_SLOTS`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
