azagrebin commented on a change in pull request #10146: [FLINK-14188][runtime]
TaskExecutor derive and register with default slot resource profile
URL: https://github.com/apache/flink/pull/10146#discussion_r348336956
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java
##########
@@ -136,6 +138,20 @@
" is typically proportional to the number of
physical CPU cores that the TaskManager's machine has" +
" (e.g., equal to the number of cores, or half
the number of cores).");
+ /**
+ * Fraction of TaskExecutor resources a default slot should take for
slot requests with unknown resource profiles.
+ */
+ @Documentation.CommonOption(position =
Documentation.CommonOption.POSITION_PARALLELISM_SLOTS)
+ public static final ConfigOption<Float> DEFAULT_SLOT_FRACTION =
+ key("taskmanager.default-slot-fraction")
+ .defaultValue(-1.0f)
+ .withDescription("For operator or user function
instances that do not specify their resource requirements,"
+ + " we use this fraction to decide how many
resources of the task executor each slot should take. A"
Review comment:
nit code style: usually we tend to put string concatenation `+` at the end
of the previous line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
