azagrebin commented on a change in pull request #10146: [FLINK-14188][runtime]
TaskExecutor derive and register with default slot resource profile
URL: https://github.com/apache/flink/pull/10146#discussion_r348382394
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/TaskExecutorResourceUtils.java
##########
@@ -86,6 +89,24 @@ private static String assembleDynamicConfigsStr(final
Map<String, String> config
// Memory Configuration Calculations
//
------------------------------------------------------------------------
+ public static TaskExecutorResourceSpec resourceSpecFromConfig(
+ final Configuration config,
+ final double cpus,
+ final MemorySize totalProcessMemory) {
Review comment:
overloading `resourceSpecFromConfig` function does not look scalable
we could consider a
`TaskExecutorResourceSpecBuilder.newBuilder(config).withCpu(cpu)...build()`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
