jackye1995 commented on code in PR #5684:
URL: https://github.com/apache/iceberg/pull/5684#discussion_r960871967
##########
aws/src/main/java/org/apache/iceberg/aws/AwsClientFactories.java:
##########
@@ -143,31 +134,12 @@ public DynamoDbClient dynamo() {
@Override
public void initialize(Map<String, String> properties) {
+ this.awsProperties = new AwsProperties(properties);
this.glueEndpoint = properties.get(AwsProperties.GLUE_CATALOG_ENDPOINT);
Review Comment:
given we already have awsProperties stored, I think we can remove all the
other variables that are duplicated in `awsProperties`
##########
aws/src/main/java/org/apache/iceberg/aws/AwsClientFactories.java:
##########
@@ -143,31 +134,12 @@ public DynamoDbClient dynamo() {
@Override
public void initialize(Map<String, String> properties) {
+ this.awsProperties = new AwsProperties(properties);
this.glueEndpoint = properties.get(AwsProperties.GLUE_CATALOG_ENDPOINT);
Review Comment:
given we already have `awsProperties` as a variable stored, I think we can
remove all the other variables that are duplicated in `awsProperties`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
