jackye1995 commented on code in PR #5684:
URL: https://github.com/apache/iceberg/pull/5684#discussion_r960878869
##########
aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java:
##########
@@ -735,4 +765,15 @@ private Set<Tag> toTags(Map<String, String> properties,
String prefix) {
public Map<String, String> s3BucketToAccessPointMapping() {
return s3BucketToAccessPointMapping;
}
+
+ public <T extends S3ClientBuilder> void applyS3Configuration(T builder) {
Review Comment:
In that case, let's focus on the default client factory and assume role one
for now, since they are the most commonly used, and see how it looks like if we
move the util methods in `AwsClientFactories` to `AwsProperties`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
