jackye1995 commented on code in PR #5684:
URL: https://github.com/apache/iceberg/pull/5684#discussion_r960877596
##########
aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java:
##########
@@ -735,4 +765,15 @@ private Set<Tag> toTags(Map<String, String> properties,
String prefix) {
public Map<String, String> s3BucketToAccessPointMapping() {
return s3BucketToAccessPointMapping;
}
+
+ public <T extends S3ClientBuilder> void applyS3Configuration(T builder) {
Review Comment:
ah I see, with this in `AwsProperties` we can do
`applyMutation(awsProperties::applyS3Configuration)` which is a clean syntax
from client factory perspective, instead of `applyMutation(builder ->
applyS3Configuration(awsProperties, builder))`. In that case I am fine. But I
think we should rethink about other util methods in `AwsClientFactories` to see
if we should move some of those as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
