JonasJ-ap commented on code in PR #5684:
URL: https://github.com/apache/iceberg/pull/5684#discussion_r961280351
##########
aws/src/main/java/org/apache/iceberg/aws/AwsClientFactories.java:
##########
@@ -143,31 +134,12 @@ public DynamoDbClient dynamo() {
@Override
public void initialize(Map<String, String> properties) {
+ this.awsProperties = new AwsProperties(properties);
this.glueEndpoint = properties.get(AwsProperties.GLUE_CATALOG_ENDPOINT);
Review Comment:
Thank you for your suggestions. I moved all endpoint fields: `glueEndpoint`,
`s3Endpoint`, and `dynamodbEndpoint` to `AwsProperties` so that we do not have
to parse them separately in every client factory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
