[
https://issues.apache.org/jira/browse/TAJO-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15085126#comment-15085126
]
ASF GitHub Bot commented on TAJO-1999:
--------------------------------------
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/891#discussion_r48933471
--- Diff:
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Schema.java
---
@@ -83,7 +82,7 @@ private static void deserializeColumn(List<Column>
tobeAdded, List<ColumnProto>
// where is start index of nested fields?
int childStartIndex = tobeAdded.size() - childNum;
// Extract nested fields
- List<Column> nestedColumns =
TUtil.newList(tobeAdded.subList(childStartIndex, childStartIndex + childNum));
+ List<Column> nestedColumns = new
ArrayList<>(tobeAdded.subList(childStartIndex, childStartIndex + childNum));
--- End diff --
Oh, this may be intended. Let's keep it.
> TUtil.newList/newLinkedHashMap should be replaced by Java's diamond operator
> ----------------------------------------------------------------------------
>
> Key: TAJO-1999
> URL: https://issues.apache.org/jira/browse/TAJO-1999
> Project: Tajo
> Issue Type: Improvement
> Reporter: Dongkyu Hwangbo
> Assignee: Dongkyu Hwangbo
> Priority: Minor
> Labels: migration, newbie
>
> We introduced Java 8. We don't need TUtil.newList/newLinkedHashMap utility
> methods anymore. We need to eliminate them.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
