[
https://issues.apache.org/jira/browse/TAJO-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15085124#comment-15085124
]
ASF GitHub Bot commented on TAJO-1999:
--------------------------------------
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/891#discussion_r48933432
--- Diff: tajo-cli/src/main/java/org/apache/tajo/cli/tools/TajoDump.java ---
@@ -169,7 +168,7 @@ private static void dumpDatabase(TajoClient client,
String databaseName, PrintWr
writer.write("\n\n");
// returned list is immutable.
- List<String> tableNames =
TUtil.newList(client.getTableList(databaseName));
+ List<String> tableNames = new
ArrayList<>(client.getTableList(databaseName));
--- End diff --
```new ArrayList()``` is redundant.
> TUtil.newList/newLinkedHashMap should be replaced by Java's diamond operator
> ----------------------------------------------------------------------------
>
> Key: TAJO-1999
> URL: https://issues.apache.org/jira/browse/TAJO-1999
> Project: Tajo
> Issue Type: Improvement
> Reporter: Dongkyu Hwangbo
> Assignee: Dongkyu Hwangbo
> Priority: Minor
> Labels: migration, newbie
>
> We introduced Java 8. We don't need TUtil.newList/newLinkedHashMap utility
> methods anymore. We need to eliminate them.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
