[
https://issues.apache.org/jira/browse/TAJO-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15055329#comment-15055329
]
ASF GitHub Bot commented on TAJO-1999:
--------------------------------------
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/891#discussion_r47457622
--- Diff:
tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/rules/ProjectionPushDownRule.java
---
@@ -962,14 +967,16 @@ public LogicalNode visitJoin(Context context,
LogicalPlan plan, LogicalPlan.Quer
}
static Iterator<String> getFilteredReferences(String [] targetNames,
Collection<String> required) {
- return new FilteredStringsIterator(targetNames, required);
+ List inputList = new ArrayList<>();
+ inputList.addAll(Arrays.asList(targetNames));
+ return new FilteredStringsIterator(inputList, required);
--- End diff --
Can be rewritten with Arrays.asList().
> TUtil.newList/newLinkedHashMap should be replaced by Java's diamond operator
> ----------------------------------------------------------------------------
>
> Key: TAJO-1999
> URL: https://issues.apache.org/jira/browse/TAJO-1999
> Project: Tajo
> Issue Type: Improvement
> Reporter: Dongkyu Hwangbo
> Assignee: Dongkyu Hwangbo
> Priority: Minor
> Labels: migration, newbie
>
> We introduced Java 8. We don't need TUtil.newList/newLinkedHashMap utility
> methods anymore. We need to eliminate them.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
