[
https://issues.apache.org/jira/browse/TAJO-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15055327#comment-15055327
]
ASF GitHub Bot commented on TAJO-1999:
--------------------------------------
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/891#discussion_r47457610
--- Diff:
tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/rules/ProjectionPushDownRule.java
---
@@ -689,7 +689,9 @@ public LogicalNode visitWindowAgg(Context context,
LogicalPlan plan, LogicalPlan
if (node.hasAggFunctions() && aggEvalNames != null) {
WindowFunctionEval [] aggEvals = new
WindowFunctionEval[aggEvalNames.length];
int i = 0;
- for (Iterator<String> it = getFilteredReferences(aggEvalNames,
TUtil.newList(aggEvalNames)); it.hasNext();) {
+ List inputList = new ArrayList<>();
+ inputList.addAll(Arrays.asList(aggEvalNames));
+ for (Iterator<String> it = getFilteredReferences(aggEvalNames,
inputList); it.hasNext();) {
--- End diff --
Can be rewritten with Arrays.asList().
> TUtil.newList/newLinkedHashMap should be replaced by Java's diamond operator
> ----------------------------------------------------------------------------
>
> Key: TAJO-1999
> URL: https://issues.apache.org/jira/browse/TAJO-1999
> Project: Tajo
> Issue Type: Improvement
> Reporter: Dongkyu Hwangbo
> Assignee: Dongkyu Hwangbo
> Priority: Minor
> Labels: migration, newbie
>
> We introduced Java 8. We don't need TUtil.newList/newLinkedHashMap utility
> methods anymore. We need to eliminate them.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
