[
https://issues.apache.org/jira/browse/TAJO-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15055334#comment-15055334
]
ASF GitHub Bot commented on TAJO-1999:
--------------------------------------
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/891#discussion_r47457655
--- Diff:
tajo-storage/tajo-storage-jdbc/src/main/java/org/apache/tajo/storage/jdbc/JdbcFragment.java
---
@@ -89,7 +93,9 @@ public boolean isEmpty() {
builder.setInputSourceId(this.inputSourceId);
builder.setUri(this.uri);
if(hostNames != null) {
- builder.addAllHosts(TUtil.newList(hostNames));
+ List inputList = new ArrayList<>();
+ inputList.addAll(Arrays.asList(hostNames));
+ builder.addAllHosts(inputList);
--- End diff --
Can be rewritten with Arrays.asList().
> TUtil.newList/newLinkedHashMap should be replaced by Java's diamond operator
> ----------------------------------------------------------------------------
>
> Key: TAJO-1999
> URL: https://issues.apache.org/jira/browse/TAJO-1999
> Project: Tajo
> Issue Type: Improvement
> Reporter: Dongkyu Hwangbo
> Assignee: Dongkyu Hwangbo
> Priority: Minor
> Labels: migration, newbie
>
> We introduced Java 8. We don't need TUtil.newList/newLinkedHashMap utility
> methods anymore. We need to eliminate them.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
